Simplify return type parsing#18206
Merged
2 commits merged intoSep 1, 2017
Merged
Conversation
ghost
requested a review
from 
ghost
changed the title
sandersn
requested changes
Sep 1, 2017
sandersn
left a comment
sandersn
left a comment
Member
There was a problem hiding this comment.
I like the top-level structure change (function + if/elif/elif/else + return) but the contents of the if-branches are weird -- one is empty, and one returns where the others don't. The current version is weird too, particularly the saving of start/length and the naming of backwardToken, and arguably the abstraction over returnToken. Overall, though, I don't think this change is worth making.
sandersn
approved these changes
Sep 1, 2017
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was some dead code around due to checking
returnTokenafter it had already been checked.