extractMethod: Don't try to extract a single token#18090
Merged
2 commits merged intoSep 7, 2017
Merged
Conversation
ghost
requested a review
from 
mhegazy
approved these changes
Sep 6, 2017
mhegazy
pushed a commit
that referenced
this pull request
Sep 10, 2017
* extractMethod: Don't try to extract a single token * Update tests
Contributor
|
Ported to release-2.5 in b1e9446 |
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18060
This isn't the only possible fix, but this is probably something we want to do anyway.