Closed
Conversation
Contributor
Author
|
The challenge I'm facing here is re-evaluating the parent tuple after generics are known, so I could spread out the generic's tuple over the parent tuple. I've yet to really figure this out. |
This was referenced Aug 21, 2017
KiaraGrouwstra
added a commit
to KiaraGrouwstra/TypeScript
that referenced
this pull request
Aug 24, 2017
Fixes the third part of microsoft#5453, needed to effectively type `bind` (Function.prototype), `curry` and `compose`. Depends on microsoft#17961 type calls, microsoft#17884 type spread and microsoft#18004 tuple spread. The first 2/3 are included, so changes will look more cluttered here though new changes just span 10 lines over 2 functions. Will properly test this when those are ready -- now still broken.
KiaraGrouwstra
force-pushed
the
5453-tuple-type-spread
branch
from
22b5361 to
57a3e46
Compare
4 tasks
Collaborator
|
Thanks for your contribution. This PR has not been updated in a while and cannot be automatically merged at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to continue working on this PR, please leave a message and one of the maintainers can reopen it. |
Contributor
Author
|
For posterity, #24897 (comment) offers an alternative we can use today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tuple type spread is part of my attempt at tackling #5453 following the tuple-flavored variant of the proposal laid out by @Artazor.
It adds a new spread node as a type-level equivalent of the one for the expression level. This could potentially be reused for another part of #5453 that'd require #6606, spreads in type-level function 'application' e.g.
Fn(...Args).Progress: evaluation with generics delayed too much.