Fix stack overflow when resolving default construct signatures#17878
Merged
Conversation
ahejlsberg
requested changes
Aug 18, 2017
ahejlsberg
left a comment
ahejlsberg
left a comment
Member
There was a problem hiding this comment.
Approved with the requested changes.
| if (!constructSignatures.length) { | ||
| constructSignatures = getDefaultConstructSignatures(classType); | ||
| } | ||
| (<ResolvedType>type).constructSignatures = constructSignatures || emptyArray; |
Member
There was a problem hiding this comment.
No need for the || emptyArray.
Member
Author
|
Travis builds are broken pending this PR since we updated our version string. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17231
Applies work done in #6091 for call signatures to construct signatures.