Async Functions by rbuckton · Pull Request #1781 · microsoft/TypeScript

rbuckton · 2015-01-23T01:52:55Z

Support for Async Functions, as per the proposal in #1664.

Adds a node factory and node tree visitor (factory.ts, factory.generated.ts)
Adds a general code generator and locals builder (generator.ts)
Adds a node rewriter for destructuring, spread element, and async functions (rewriter.ts)
Adds support for parsing async functions and the await keyword (scanner.ts, parser.ts)
Adds type check for await and async function return types
Adds call to rewriter for async functions during emit (emitter.ts)
Adds __awaiter and __generator helper functions to emit output (emitter.ts)

…nBlock

- fixed label fall-through - added implicit return - disallow 'with' in async - fixed ASI ambiguity with 'async' by disallowing newline - cleanup rewrite of ForInStatement

…t in some rewritten nodes

…'this'

…nged how catch variables are renamed

…ating unique generated identifiers

…ve comments in rewrite

JsonFreeman · 2015-02-14T01:14:44Z

src/compiler/checker.ts

When you say "the type has a construct signature...", you don't really mean the type. You mean the type resulting from resolving the name of that type as a value.

…ervices.ts

JsonFreeman · 2015-02-14T09:29:34Z

src/compiler/parser.ts

I understand now. This is very ES6-y. I prefer the model where ambient flags are passed by just doing nothing, and flags are explicitly turned on and off. I know that what you've done here is more to the grammar, but for some reason I find it less intuitive.

teobugslayer · 2015-05-06T12:52:59Z

Hello @rbuckton,

I've tried to use your branch and found a compiler crash. Using this code:

async function read(): string {
    return "";
}

gives this output:

c:\Work\asyncpoc\node_modules\typescript\bin\tsc.js:10207
                    if (target.flags & 1)
                              ^
TypeError: Cannot read property 'flags' of undefined
    at isRelatedTo (c:\Work\asyncpoc\node_modules\typescript\bin\tsc.js:10207:31)
    at checkTypeRelatedTo (c:\Work\asyncpoc\node_modules\typescript\bin\tsc.js:10183:26)
    at checkTypeAssignableTo (c:\Work\asyncpoc\node_modules\typescript\bin\tsc.js:10167:20)
    at checkReturnStatement (c:\Work\asyncpoc\node_modules\typescript\bin\tsc.js:14272:29)
    at checkSourceElement (c:\Work\asyncpoc\node_modules\typescript\bin\tsc.js:15005:28)
    at Object.forEach (c:\Work\asyncpoc\node_modules\typescript\bin\tsc.js:74:30)
    at checkBlock (c:\Work\asyncpoc\node_modules\typescript\bin\tsc.js:13881:16)
    at checkSourceElement (c:\Work\asyncpoc\node_modules\typescript\bin\tsc.js:14986:28)
    at checkFunctionLikeDeclaration (c:\Work\asyncpoc\node_modules\typescript\bin\tsc.js:13863:13)
    at checkFunctionDeclaration (c:\Work\asyncpoc\node_modules\typescript\bin\tsc.js:13838:17)

I am using node 0.12.2 x64 on Windows 8.1 and the tsconfig.json is:

{
    "compilerOptions": {
        "module": "commonjs",
        "noImplicitAny": true,
        "removeComments": false,
        "preserveConstEnums": true,
        "sourceMap": true,
        "target": "ES6"
    },
    "files": [ "index.ts", "node.d.ts" ]
}

Hope this helps!

mhegazy · 2015-06-19T00:17:35Z

closing this in favor of: #3078

tinganho · 2015-06-19T00:22:34Z

@mhegazy does this mean async functions are only supported in ES6? Then why is that?

rbuckton · 2015-06-19T00:34:42Z

@tinganho Downlevel support for async functions will likely end up in a separate PR. This one is extremely out of date.

tinganho · 2015-06-19T00:39:15Z

Ok thanks for explanation @rbuckton . I really want this feature in at least ES5 too.

nippur72 · 2015-07-22T17:13:48Z

@teobugslayer perhaps it's related to #3978, with the difference that one is in the master branch.

coveralls · 2016-09-15T23:55:17Z

Changes Unknown when pulling d57fe72 on prototypeAsync into * on master*.

rbuckton added 30 commits November 22, 2014 00:08

Added 'async' and 'await' keywords to parser

0a889c6

Adding some tests for 'async'

def7460

Added async/await to checker

96c44b3

Added factory, rewriter, and emit for generated nodes.

d51b8bd

Renamed BodyGenerator to CodeGenerator, removed offsets from Exceptio…

bf28560

…nBlock

Merge 'master' to 'prototypeAsync'

a60cd3a

- cleaned up rewriter

1f190ba

- fixed label fall-through - added implicit return - disallow 'with' in async - fixed ASI ambiguity with 'async' by disallowing newline - cleanup rewrite of ForInStatement

Fixed whitespace in Jakefile

f8bbe78

merged 'master' to 'prototypeAsync'

ead809b

Fix for breaks following merge

4fad214

Fix for labels, emitGeneratedNode indentation, and bugs in emit outpu…

7c8fd3d

…t in some rewritten nodes

rewrite of function parameters with initializers and fixed capturing …

4dac41a

…'this'

Merge branch 'master' into prototypeAsync

389962b

Added additional diagnostics around __awaiter and __generator and cha…

d2bdf6e

…nged how catch variables are renamed

Tests for async/await, plus bugfixes

a8c8918

Added updated reference files for test cases

dc2e6bd

More tests, cleanup for code generator, switched to mechanism for cre…

938e0cd

…ating unique generated identifiers

fix for type check of reserved identifiers in compiler.

868cf6d

Refactored generated locals to a separate object, some work to preser…

6c3eace

…ve comments in rewrite

Fixed comment emit for nodes inside of a generated node.

1488944

More cleanup for comment preservation

cb4bc4f

Updated tests, fix for variable statement emit

faaf778

centralized getPromiseConstructor to checker.ts

cfdb9ac

Updated sourcemap output for generated nodes

4ade643

cleaned up generated code

155b9a5

Updated test baselines, fixed error in for..in rewrite

38d2218

First pass at merge from master

1de7be3

Fixed diagnostic message numbering, updated some baselines

18c2d50

Updated baselines from master

26c6b80

Updated baselines

a097c2b

JsonFreeman reviewed Feb 14, 2015
View reviewed changes

rbuckton and others added 3 commits February 13, 2015 19:26

A number of updates based on CR feedback

763edc6

Merge branch 'master' into prototypeAsync

ab3f342

Fixed error in colorization.ts in unit tests after recent change to s…

aece9ae

…ervices.ts

JsonFreeman reviewed Feb 14, 2015
View reviewed changes

rbuckton added 3 commits February 25, 2015 16:16

Fixes for PR comments and updated baselines.

4c132c9

Various updates from PR feedback.

60a0a49

Updated LKG

d57fe72

rbuckton mentioned this pull request May 8, 2015

Async Functions for ES6 #3078

Merged

mhegazy closed this Jun 19, 2015

DanielRosenwasser mentioned this pull request Jul 22, 2015

Transpiling ES6 generators into a ES5 state machine? #3975

Closed

rbuckton deleted the prototypeAsync branch September 16, 2016 00:09

microsoft locked and limited conversation to collaborators Jun 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Async Functions#1781

Async Functions#1781
rbuckton wants to merge 112 commits intomasterfrom
prototypeAsync

rbuckton commented Jan 23, 2015

Uh oh!

JsonFreeman Feb 14, 2015

Uh oh!

JsonFreeman Feb 14, 2015

Uh oh!

teobugslayer commented May 6, 2015

Uh oh!

mhegazy commented Jun 19, 2015

Uh oh!

tinganho commented Jun 19, 2015

Uh oh!

rbuckton commented Jun 19, 2015

Uh oh!

tinganho commented Jun 19, 2015

Uh oh!

nippur72 commented Jul 22, 2015

Uh oh!

coveralls commented Sep 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

rbuckton commented Jan 23, 2015

Uh oh!

JsonFreeman Feb 14, 2015

Choose a reason for hiding this comment

Uh oh!

JsonFreeman Feb 14, 2015

Choose a reason for hiding this comment

Uh oh!

teobugslayer commented May 6, 2015

Uh oh!

mhegazy commented Jun 19, 2015

Uh oh!

tinganho commented Jun 19, 2015

Uh oh!

rbuckton commented Jun 19, 2015

Uh oh!

tinganho commented Jun 19, 2015

Uh oh!

nippur72 commented Jul 22, 2015

Uh oh!

coveralls commented Sep 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants