In services, show the aliasSymbol for a type even if it's not accessible in the current scope#17433
Conversation
…ble in the current scope
ghost
requested a review
from 
ghost
mentioned this pull request
aozgaa
reviewed
Aug 4, 2017
src/compiler/types.ts
Outdated
| AddUndefined = 1 << 13, // Add undefined to types of initialized, non-optional parameters | ||
| WriteClassExpressionAsTypeLiteral = 1 << 14, // Write a type literal instead of (Anonymous class) | ||
| InArrayType = 1 << 15, // Writing an array element type | ||
| UseAliasEvenIfNotAccessible = 1 << 16, // For a `type T = ... ` defined in a different file, write `T` instead of its value, |
Contributor
There was a problem hiding this comment.
maybe "defined outside the current scope"?
aozgaa
reviewed
Aug 4, 2017
src/compiler/types.ts
Outdated
| AddUndefined = 1 << 13, // Add undefined to types of initialized, non-optional parameters | ||
| WriteClassExpressionAsTypeLiteral = 1 << 14, // Write a type literal instead of (Anonymous class) | ||
| InArrayType = 1 << 15, // Writing an array element type | ||
| UseAliasEvenIfNotAccessible = 1 << 16, // For a `type T = ... ` defined in a different file, write `T` instead of its value, |
Contributor
There was a problem hiding this comment.
This seems suspiciously correlated to UseTypeAliasValue. I'm not sure what the right way to emphasize the difference is, but it seems like a smell.
Author
|
@aozgaa, good to go? |
Contributor
|
LGTM |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17322
This may show an unexpected type due to #17349 -- if there is
type T = string | numbersomewhere and you happen to also havestring | numberin your file, you will seeT. But such situations will hopefully be rare.