Skip to content

Contextually type this in object literals in JS #17252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandersn merged 2 commits into from
Jul 18, 2017
Merged

Contextually type this in object literals in JS #17252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08ae022
Contextually type this in object literals in JS
sandersn Jul 17, 2017
95f5bc1
Add unknown property to test of contextual this type
sandersn Jul 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12602,7 +12602,7 @@ namespace ts {
}
}
}
if (noImplicitThis) {
if (noImplicitThis || isInJavaScriptFile(func)) {
const containingLiteral = getContainingObjectLiteral(func);
if (containingLiteral) {
// We have an object literal method. Check if the containing object literal has a contextual type
Expand Down
28 changes: 28 additions & 0 deletions tests/baselines/reference/contextualThisTypeInJavascript.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
=== tests/cases/conformance/types/thisType/context.js ===
const obj = {
>obj : Symbol(obj, Decl(context.js, 0, 5))

prop: 2,
>prop : Symbol(prop, Decl(context.js, 0, 13))

method() {
>method : Symbol(method, Decl(context.js, 1, 12))

this;
>this : Symbol(obj, Decl(context.js, 0, 11))

this.prop;
>this.prop : Symbol(prop, Decl(context.js, 0, 13))
>this : Symbol(obj, Decl(context.js, 0, 11))
>prop : Symbol(prop, Decl(context.js, 0, 13))

this.method;
>this.method : Symbol(method, Decl(context.js, 1, 12))
>this : Symbol(obj, Decl(context.js, 0, 11))
>method : Symbol(method, Decl(context.js, 1, 12))

this.unknown; // ok, obj has a string indexer
>this : Symbol(obj, Decl(context.js, 0, 11))
}
}

32 changes: 32 additions & 0 deletions tests/baselines/reference/contextualThisTypeInJavascript.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
=== tests/cases/conformance/types/thisType/context.js ===
const obj = {
>obj : { [x: string]: any; prop: number; method(): void; }
>{ prop: 2, method() { this; this.prop; this.method; this.unknown; // ok, obj has a string indexer }} : { [x: string]: any; prop: number; method(): void; }

prop: 2,
>prop : number
>2 : 2

method() {
>method : () => void

this;
>this : { [x: string]: any; prop: number; method(): void; }

this.prop;
>this.prop : number
>this : { [x: string]: any; prop: number; method(): void; }
>prop : number

this.method;
>this.method : () => void
>this : { [x: string]: any; prop: number; method(): void; }
>method : () => void

this.unknown; // ok, obj has a string indexer
>this.unknown : any
>this : { [x: string]: any; prop: number; method(): void; }
>unknown : any
}
}

13 changes: 13 additions & 0 deletions tests/cases/conformance/types/thisType/contextualThisTypeInJavascript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// @allowJs: true
// @checkJs: true
// @noEmit: true
// @Filename: context.js
const obj = {
prop: 2,
method() {
this;
this.prop;
this.method;

@ghost ghost Jul 18, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for unknown property. Should be no error, get any.

this.unknown; // ok, obj has a string indexer
}
}