Code fix prefix unused2#16309
Merged
Merged
Conversation
mhegazy
reviewed
Jun 6, 2017
| case ts.SyntaxKind.Identifier: | ||
| return deleteIdentifier(); | ||
| let actions = deleteIdentifier(<Identifier>token); | ||
| (actions || (actions = [])).push(prefixIdentifierWithUnderscore(<Identifier>token)); |
Contributor
There was a problem hiding this comment.
we should not do this all the time. only for parameters and for..of/for .. in variables
mhegazy
reviewed
Jun 6, 2017
| //// } |] | ||
|
|
||
| verify.rangeAfterCodeFix(`namespace greeter { | ||
| class _class1 { } |
mhegazy
suggested changes
Jun 6, 2017
mhegazy
left a comment
mhegazy
left a comment
Contributor
There was a problem hiding this comment.
we need to condition the _ addition
* for-in * for-of * parameters
Contributor
Author
|
@mhegazy can you take another look? |
mhegazy
approved these changes
Jun 12, 2017
Contributor
|
please port this to release-2.4 |
aozgaa
pushed a commit
to aozgaa/TypeScript
that referenced
this pull request
Jun 13, 2017
aozgaa
added a commit
that referenced
this pull request
Jun 14, 2017
port #16309 (prefix unused with _) to release-2.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14420.
Note that we do not add underscores for parameter declarations or imports, as underscores do no work for suppressing unused errors for these constructs.