Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/compiler/checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14522,6 +14522,7 @@ namespace ts {
const maximumLengthDifference = Math.min(3, name.length * 0.34);
let bestDistance = Number.MAX_VALUE;
let bestCandidate = undefined;
let justCheckExactMatches = false;
if (name.length > 30) {
return undefined;
}
Expand All @@ -14534,6 +14535,9 @@ namespace ts {
if (candidateName === name) {
return candidate;
}
if (justCheckExactMatches) {
continue;
}
if (candidateName.length < 3 ||
name.length < 3 ||
candidateName === "eval" ||
Expand All @@ -14549,7 +14553,8 @@ namespace ts {
continue;
}
if (distance < 3) {
return candidate;
justCheckExactMatches = true;
bestCandidate = candidate;
}
else if (distance < bestDistance) {
bestDistance = distance;
Expand Down
16 changes: 16 additions & 0 deletions tests/baselines/reference/exactSpellingSuggestion.errors.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
tests/cases/compiler/exactSpellingSuggestion.ts(9,4): error TS2551: Property 'bit_2' does not exist on type 'typeof U8'. Did you mean 'BIT_2'?


==== tests/cases/compiler/exactSpellingSuggestion.ts (1 errors) ====
// Fixes #16245 -- always suggest the exact match, even when
// other options are very close
enum U8 {
BIT_0 = 1 << 0,
BIT_1 = 1 << 1,
BIT_2 = 1 << 2
}

U8.bit_2
~~~~~
!!! error TS2551: Property 'bit_2' does not exist on type 'typeof U8'. Did you mean 'BIT_2'?

22 changes: 22 additions & 0 deletions tests/baselines/reference/exactSpellingSuggestion.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
//// [exactSpellingSuggestion.ts]
// Fixes #16245 -- always suggest the exact match, even when
// other options are very close
enum U8 {
BIT_0 = 1 << 0,
BIT_1 = 1 << 1,
BIT_2 = 1 << 2
}

U8.bit_2


//// [exactSpellingSuggestion.js]
// Fixes #16245 -- always suggest the exact match, even when
// other options are very close
var U8;
(function (U8) {
U8[U8["BIT_0"] = 1] = "BIT_0";
U8[U8["BIT_1"] = 2] = "BIT_1";
U8[U8["BIT_2"] = 4] = "BIT_2";
})(U8 || (U8 = {}));
U8.bit_2;
9 changes: 9 additions & 0 deletions tests/cases/compiler/exactSpellingSuggestion.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Fixes #16245 -- always suggest the exact match, even when
// other options are very close
enum U8 {
BIT_0 = 1 << 0,
BIT_1 = 1 << 1,
BIT_2 = 1 << 2
}

U8.bit_2