Compiler Layering#1512
Merged
Merged
Conversation
…ow it. The layering is now: types core scanner parser binder checker emitter program
…gnostics. Comment what the flag means.
This breaks layering. Also, it means the emitter depends on too large a surface area. Now the emitter declares exactly what it needs, and only gets that.
CyrusNajmabadi
force-pushed
the
layering
branch
from
1380ac7 to
b665323
Compare
Member
There was a problem hiding this comment.
Update the preceding comment.
Instead, these layers explicitly specify the functionality they need, and don't take in anything extra.
Member
There was a problem hiding this comment.
Add "program.ts" to thedefinitionsRoots`.
…to contort compiler hosts.
Conflicts: src/compiler/checker.ts src/compiler/parser.ts
Conflicts: src/compiler/checker.ts src/compiler/utilities.ts
Conflicts: src/compiler/parser.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and then
services
With this, anyone can now open any layer of the compiler and have it correctly work in the IDE, as well as build it from the command line.
Note: this is a work in progress. there are still additional commits coming.