Skip to content

Fix Headers interface #15050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhegazy merged 3 commits into from
Apr 24, 2017
Merged

Fix Headers interface #15050

mhegazy merged 3 commits into from
Apr 24, 2017

Conversation

@YuichiNukiyama
Copy link
Contributor

@YuichiNukiyama YuichiNukiyama commented Apr 6, 2017

Fixes #14412

@saschanaz
Copy link
Contributor

saschanaz commented Apr 24, 2017 •
edited
Loading

[Symbol.iterator]: IterableIterator<[string, string]> is required too.

@YuichiNukiyama
Copy link
Contributor Author

YuichiNukiyama commented Apr 24, 2017

@saschanaz
Thanks for your advise. I add Symbol.iterator.

@saschanaz
Copy link
Contributor

saschanaz commented Apr 24, 2017

Uh, sorry for case issue, it should be string instead of String.

@YuichiNukiyama
Copy link
Contributor Author

YuichiNukiyama commented Apr 24, 2017

oops. i make careless miss.

@mhegazy mhegazy merged commit bb8a875 into microsoft:master Apr 24, 2017
@YuichiNukiyama YuichiNukiyama deleted the add_headers_iteratableiterator branch April 24, 2017 21:35
@microsoft microsoft locked and limited conversation to collaborators Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YuichiNukiyama @saschanaz @mhegazy @msftclas