Add advanced safelist for exclusions#14999
Merged
Merged
Conversation
j-oliveras
reviewed
Apr 4, 2017
| content: JSON.stringify({ | ||
| "jquery": { | ||
| // jquery files can have names like "jquery-1.10.2.min.js" (or "jquery.intellisense.js") | ||
| "match": "/jquery(-(\\.\\d+)+)?(\\.intellisense)?(\\.min)?\\.js$", |
Contributor
There was a problem hiding this comment.
This don't match jquery-1.10.2.min.js, matches something like jquery-.10.2.min.js.
RyanCavanaugh
changed the title
RyanCavanaugh
commented
Apr 7, 2017
| const raw: SafeList = JSON.parse(this.host.readFile(fileName, "utf-8")); | ||
| // Parse the regexps | ||
| for (const k of Object.keys(raw)) { | ||
| raw[k].match = new RegExp(raw[k].match as {} as string, "gi"); |
minestarks
approved these changes
Apr 7, 2017
| export type LoadTypesMap = "loadTypesMap"; | ||
| export type GetCodeFixes = "getCodeFixes"; | ||
| /* @internal */ | ||
| /* @internal */ |
| return this.requiredResponse(true); | ||
| }, | ||
| [CommandNames.LoadTypesMap]: (request: protocol.FileRequest) => { | ||
| const loadArgs = <protocol.FileRequestArgs>request.arguments; |
Member
There was a problem hiding this comment.
FileRequestArgs has a projectFileName member which you never look at. While it's optional, it still gives the false impression that project context matters for this message (it doesn't -- it loads the same type map for all projects). I'd use a different type that only contains file.
This was referenced Apr 10, 2017
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.