Update tslint to latest (next is still on 4.3) and lint for BOM#14391
Merged
3 commits merged intoMar 7, 2017
Merged
Conversation
ghost
ghost
mentioned this pull request
Contributor
|
there was a reason why we used @next. @vladima and @DanielRosenwasser do you recall why? |
Contributor
|
node v4 seems to be failing, can not seem to see the logs, possibly |
Contributor
|
AFAIR the problem was that |
ghost
mentioned this pull request
Contributor
|
Just published tslint v4.5.1-dev.0 and v5.0.0-dev.0 with the |
Contributor
|
👍 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BOM was causing
^Mto show up in edited files.tslint@nexthasn't been updated in a while, so perhaps we should uselatestinstead?