Add support for handling .js file incorrectly in fixAddMissingMember code fix#14276
Merged
Add support for handling .js file incorrectly in fixAddMissingMember code fix#14276
Conversation
Contributor
Author
|
Merged in #14496 to enable write tests. |
Contributor
|
Looks good to me. Just want to note that this and other codefix changes will need to be ported to work with AST node synthesis in the near future (this or next week?). we might want to temporarily suspend work on adding more quickfix functionality until we get that in. For example, I've actually ported this |
aozgaa
reviewed
Mar 14, 2017
| fileName: sourceFile.fileName, | ||
| textChanges: [{ | ||
| span: { start: startPos, length: 0 }, | ||
| newText: `${token.getFullText(sourceFile)}: ${typeString};` |
Contributor
There was a problem hiding this comment.
token.getFullText should probably be token.getText.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing tests, but there is not a way to get the error to show at the moment.