Remove 'isOpen' and 'version' from teh compiler's SourceFile type.#1420
Merged
Conversation
Also, provide a way for creators of a source file to specify if they want parent nodes hooked up.
Contributor
|
👍 |
CyrusNajmabadi
added a commit
that referenced
this pull request
Dec 10, 2014
Remove 'isOpen' and 'version' from teh compiler's SourceFile type.
Contributor
There was a problem hiding this comment.
why set to true all the time. this method is used for both semantic and syntactic features. we only need to set hte parents in the syntactic ones.
Member
There was a problem hiding this comment.
This is actually based on a failed cherry pick of that commit ;)
Contributor
Author
|
@mhegazy Good point! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, provide a way for creators of a source file to specify if they
want parent nodes hooked up.