Skip to content

Emit default param natively in ES6 - #1377

Closed
Yui (yuit) wants to merge 4 commits into
emitRestParamNativelyfrom
emitDefaultParamNatively
Closed

Yui (yuit) wants to merge 4 commits into
emitRestParamNativelyfrom
emitDefaultParamNatively

Conversation

@yuit

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/compiler/emitter.ts

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is now in the singular instead of the plural (i.e. assignment vs assignments).

I think either change it back to emitDefaultValueAssignments or make it emitDownlevelParameterInitializers.

@CyrusNajmabadi

Copy link
Copy Markdown
Contributor

👍

@DanielRosenwasser

Copy link
Copy Markdown
Member

Can we get some tests for the following?

  • Rest parameters with default arguments
  • Parenthesized comma expressions

@ahejlsberg

Copy link
Copy Markdown
Member

Superceded by #1463.

@yuit
Yui (yuit) deleted the emitDefaultParamNatively branch February 12, 2015 18:27
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants