Repository navigation
Emit rest parameters natively in ES6 - #1370
Closed
Yui (yuit) wants to merge 5 commits into
Closed
Yui (yuit) wants to merge 5 commits into
Yui (yuit) wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
remove this please
Member
|
👍 |
There was a problem hiding this comment.
Why not just have
if (options.target < ScriptTarget.ES6) {
emitCommaList(node.parameters, /*includeTrailingComma*/ false, numberOfParameters - (hasRestParam ? 1 : 0));
}
else {
emitCommaList(node.parameters, /*includeTrailingComma*/ false, numberOfParameters);
}and make a modified emitParameter with
if (node.flags & NodeFlags.Rest) {
write("...");
}and also rename the existing emitParameter to emitDownlevelParameter?
Contributor
There was a problem hiding this comment.
This sounds better to me as well.
Contributor
|
💯 |
Member
|
Superceded by #1463. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.