Skip to content

#13063 Fix strictNullChecks breaking typeof #13192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhegazy merged 2 commits into from
Dec 28, 2016
Merged

#13063 Fix strictNullChecks breaking typeof #13192

mhegazy merged 2 commits into from
Dec 28, 2016

Conversation

@slawomir
Copy link
Contributor

@slawomir slawomir commented Dec 28, 2016 •
edited by DanielRosenwasser
Loading

Fixes #13063

@slawomir
microsoft#13063 Fix strictNullChecks breaking typeof
498568b 
 * Allow typeof to use not-auto variable in strictNullChecks mode
@slawomir slawomir mentioned this pull request Dec 28, 2016
Closed
RyanCavanaugh
RyanCavanaugh reviewed Dec 28, 2016
View reviewed changes
src/compiler/checker.ts Outdated
// declaration container are the same).
const assumeInitialized = isParameter || isOuterVariable ||
type !== autoType && type !== autoArrayType && (!strictNullChecks || (type.flags & TypeFlags.Any) !== 0) ||
type !== autoType && type !== autoArrayType && (!strictNullChecks || isInTypeQuery(node) || (type.flags & TypeFlags.Any) !== 0) ||
Copy link
Member

@RyanCavanaugh RyanCavanaugh Dec 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this condition last in the || chain - we want the faster checks first and isInTypeQuery has to walk up the entire tree

Copy link
Contributor Author

@slawomir slawomir Dec 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RyanCavanaugh updated pull request

@slawomir
microsoft#13063 Optimization
5317f13 
Add isInTypeQuery as the last OR
@mhegazy mhegazy merged commit e128b94 into microsoft:master Dec 28, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

+2 more reviewers

@mhegazy mhegazy mhegazy approved these changes

@vladima vladima vladima approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@slawomir @RyanCavanaugh @mhegazy @vladima @msftclas