Skip to content

Aggregate transform flags for ExpressionWithTypeArguments #13191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhegazy merged 1 commit into from
Dec 28, 2016
Merged

Aggregate transform flags for ExpressionWithTypeArguments #13191

mhegazy merged 1 commit into from
Dec 28, 2016

Conversation

@rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Dec 28, 2016 •
edited by DanielRosenwasser
Loading

We were failing to aggregate the transform flags for an ExpressionWithTypeArguments on subsequent transformation passes as ExpressionWithTypeArguments is considered to be a type.

Fixes #13157

@rbuckton rbuckton requested review from mhegazy and vladima December 28, 2016 02:00
@mhegazy mhegazy merged commit b82fe52 into master Dec 28, 2016
@rbuckton rbuckton deleted the fix13157 branch December 28, 2016 23:55
@mhegazy mhegazy mentioned this pull request Dec 29, 2016
Merged
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mhegazy mhegazy Awaiting requested review from mhegazy

1 more reviewer

@vladima vladima vladima approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rbuckton @vladima @mhegazy @msftclas