Skip to content

Fixed bug where tagged templates with a literal adjacent to EOF showed sig help past the end.#1271

Merged
DanielRosenwasser merged 3 commits into
masterfrom
taggedSigHelpAtEnd
Feb 12, 2015
Merged

Fixed bug where tagged templates with a literal adjacent to EOF showed sig help past the end.#1271
DanielRosenwasser merged 3 commits into
masterfrom
taggedSigHelpAtEnd

Conversation

@DanielRosenwasser

Copy link
Copy Markdown
Member

No description provided.

@DanielRosenwasser DanielRosenwasser changed the title Fixed bug where tagged templates with a literal adjacent to EOF showed sig help. Fixed bug where tagged templates with a literal adjacent to EOF showed sig help past the end. Nov 25, 2014
Comment thread src/compiler/parser.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand this line of comment

Conflicts:
	src/compiler/parser.ts
	src/services/signatureHelp.ts
@mhegazy

mhegazy commented Feb 9, 2015

Copy link
Copy Markdown
Contributor

👍

DanielRosenwasser added a commit that referenced this pull request Feb 12, 2015
Fixed bug where tagged templates with a literal adjacent to EOF showed sig help past the end.
@DanielRosenwasser DanielRosenwasser merged commit 3e8babe into master Feb 12, 2015
@DanielRosenwasser DanielRosenwasser deleted the taggedSigHelpAtEnd branch February 12, 2015 19:37
@DanielRosenwasser DanielRosenwasser removed their assignment Feb 28, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants