Fix elided syntax kinds falling through to visitConstructor in TypeScript transformer#12639
Merged
DanielRosenwasser merged 1 commit intoDec 3, 2016
Conversation
…ript transformer.
|
Hi @MattiasBuelens, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
Member
|
Thanks for catching that! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TypeScript transformer elides a bunch of syntax kinds that should not appear in the emitted JavaScript code (e.g. access modifiers, types,...). Normally, this elision would be done by returning
undefinedfrom the visitor.This commit changed the handling for
SyntaxKind.Constructor: previously constructors were elided, but nowvisitConstructorhandles them. However, the commit forgot to stop the cases above theSyntaxKind.Constructorcase falling through, so now all cases that should just havereturn undefinedactually callvisitConstructorinstead. Luckily,visitConstructorreturnsundefinedwhen its argument is not a function-like declaration, which is why the code works and passes the tests... although it works for the wrong reason. 😛This change re-introduces the missing
return undefinedstatement, so the elided cases no longer fall through tovisitConstructor.