tsserver: get candidates from <K extends keyof Foo> (fix #12536) #12543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wonderful-panda, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
| } | ||
|
|
||
| function addStringLiteralCompletionsFromType(type: Type, result: CompletionEntry[]): void { | ||
| if (type && type.flags & TypeFlags.TypeParameter) { |
Member
There was a problem hiding this comment.
If you get the type constraint and the type is a keyof type, where is that handled below?
mhegazy
approved these changes
Nov 28, 2016
src/services/completions.ts
Outdated
|
|
||
| function addStringLiteralCompletionsFromType(type: Type, result: CompletionEntry[]): void { | ||
| if (type && type.flags & TypeFlags.TypeParameter) { | ||
| type = (<TypeParameter>type).constraint; |
Contributor
There was a problem hiding this comment.
you should use checker::getApparentType here instead. it does some more than just checking the constraint.
Contributor
There was a problem hiding this comment.
to do that, you will need to expose this method on TypeChecker interface.
Contributor
Author
|
Thank you for the review. I've pushed new version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12536