Conversation
Since __assign defaults to Object.assign if present, our own helper will never be used in ES6 and higher, and `getOwnPropertySymbols` is not needed in ES5 and below because symbols don't exist there.
Member
Author
|
@rbuckton here's the __assign improvement you suggested. |
Contributor
Member
Author
|
Sure. Done. |
rbuckton
approved these changes
Nov 16, 2016
Contributor
|
The premise is not strictly true. Object.assign and Object.getOwnPropertySymbols may be polyfilled (one of them or both). It's safer to feature-detect each on separately, rather than rely on presence of one as a clue to another. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
__assigndefaults toObject.assignif present, our own helper will never be used in ES6 and higher, andgetOwnPropertySymbolsis not needed in ES5 and below because symbols don't exist there.