Using shorthand property assignment in compiler#1198
Merged
Conversation
added 8 commits
November 18, 2014 11:39
Contributor
There was a problem hiding this comment.
i would rename the variable diagnostics to be errors, or rename the property in the interface to be diagnostics. i would prefer renaming errors to diagnostics as this is more accurate.
Contributor
|
👍 |
Contributor
|
also can you update the LKG in master once you merge. |
Contributor
Author
|
Yep I will |
Contributor
|
👍 |
added 3 commits
November 18, 2014 16:32
Conflicts: bin/tsc.js bin/typescriptServices.js src/compiler/parser.ts
yuit
pushed a commit
that referenced
this pull request
Nov 19, 2014
Using shorthand property assignment in compiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LKG and use short-hand property assignment in compiler