Skip to content

remove redundant type assertion#11347

Merged
RyanCavanaugh merged 1 commit into
microsoft:masterfrom
HerringtonDarkholme:remove-redundant
Oct 10, 2016
Merged

remove redundant type assertion#11347
RyanCavanaugh merged 1 commit into
microsoft:masterfrom
HerringtonDarkholme:remove-redundant

Conversation

@HerringtonDarkholme

Copy link
Copy Markdown
Contributor

Just find an unnecessary assertion while browsing code

@HerringtonDarkholme

Copy link
Copy Markdown
Contributor Author

ping @mhegazy @rbuckton

@RyanCavanaugh RyanCavanaugh merged commit fe32282 into microsoft:master Oct 10, 2016
@RyanCavanaugh

Copy link
Copy Markdown
Member

Thanks!

If you want some low-hanging fruit for a fun PR, it's fairly easy to hack in an error report when the asserted type is identical to the expression type.

@HerringtonDarkholme HerringtonDarkholme deleted the remove-redundant branch October 18, 2016 06:22
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants