Skip to content

do not reset current flow after processing finally block if it was unreachable #11310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vladima merged 2 commits into from
Oct 3, 2016
Merged

do not reset current flow after processing finally block if it was unreachable #11310

vladima merged 2 commits into from
Oct 3, 2016

Conversation

@vladima
Copy link
Contributor

@vladima vladima commented Oct 2, 2016

fixes #11307

mhegazy
mhegazy reviewed Oct 3, 2016
View reviewed changes
tests/cases/compiler/unreachableFlowAfterFinally.ts
@@ -0,0 +1,12 @@
function f() {
Copy link
Contributor

@mhegazy mhegazy Oct 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noImplicitReturns: true

mhegazy
mhegazy approved these changes Oct 3, 2016
View reviewed changes
Copy link
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with test updates

@vladima vladima merged commit 4800464 into master Oct 3, 2016
@vladima vladima deleted the vladima/unreachable-state-after-finally branch October 3, 2016 18:03
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'finally' clause not accounted for in control flow analysis

4 participants

@vladima @mhegazy @msftclas