change error message for assigning from object#10961
Merged
Merged
Conversation
Member
|
The results look positive overall - @sandersn @RyanCavanaugh care to take a look? |
sandersn
approved these changes
Sep 20, 2016
sandersn
left a comment
sandersn
left a comment
Member
There was a problem hiding this comment.
Very nice improvement. If it's not too much trouble, can you fix the typo in the filename "assigningFrom_Object_ToAnythingElse.ts" ?
Contributor
Author
|
Thanks. I fix file name typo. |
Member
|
You also need to delete the original, typoed baselines. The baselines passed even without deleting them though, I'm not sure why. |
Contributor
Author
|
I remove extra files.
If I have a time, try to investigate. |
Member
|
Looks good. Thanks again @YuichiNukiyama ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10462