Surfacing method to get Completion Symbol#10813
Merged
Merged
Conversation
added 2 commits
September 9, 2016 09:25
|
Hi @MicrosoftSam, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| // We don't need to perform character checks here because we're only comparing the | ||
| // name against 'entryName' (which is known to be good), not building a new | ||
| // completion entry. | ||
| const symbol = forEach(symbols, s => getCompletionEntryDisplayNameForSymbol(typeChecker, s, compilerOptions.target, /*performCharacterChecks*/ false, location) === entryName ? s : undefined); |
Contributor
There was a problem hiding this comment.
just return the result of forEach. it will return a symbol|undefined which is what you want.
Contributor
|
one small style comment, otherwise we are good to go. |
Author
|
Okay, I'll get that in right away. |
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10812
Surfacing method to get Completion Symbol instead of details for better extensibility.