Since many of these functions used to be inside a big closure in services.ts, I've had to add new parameters to many of them.

Note that when moving functions out I often create closure/no-closure pairs.

For example, when extracting out getDocumentHighlights, the new signature has new parameters:

export function getDocumentHighlights(typeChecker: TypeChecker, cancellationToken: CancellationToken, sourceFile: SourceFile, position: number, sourceFilesToSearch: SourceFile[]): DocumentHighlights[] {

So to satisfy the old signatures, we get parameters from the closure and then pass them in.

// Inside closure in services.ts
function getDocumentHighlights(fileName: string, position: number, filesToSearch: string[]): DocumentHighlights[] {
    synchronizeHostData();
    const sourceFilesToSearch = map(filesToSearch, f => program.getSourceFile(f));
    const sourceFile = getValidSourceFile(fileName);
    return DocumentHighlights.getDocumentHighlights(program.getTypeChecker(), cancellationToken, sourceFile, position, sourceFilesToSearch);
}

Here are the changes:

allocators.ts: 625 lines

Exports: getServicesObjectAllocator, a new function I made so that this module would need only 1 export.

classifier.ts: 982 lines

Exports: createClassifier, getSemanticClassifications, getEncodedSemanticClassifications, getSyntacticClassifications, getEncodedSyntacticClassifications

New parameters:

• checkForClassificationCancellation: cancellationToken
• getSemanticClassifications: typeChecker, cancellationToken, sourceFile, classifiableNames
• getEncodedSemanticClassifications: typeChecker, cancellationToken, sourceFile, classifiableNames
• getSyntacticClassifications: cancellationToken, sourceFile
• getEncodedSyntacticClassifications: cancellationToken, sourceFile

completions.ts: 1186 lines

Exports: getCompletionsAtPosition, getCompletionEntryDetails

New parameters:

• getCompletionEntryDisplayNameForSymbol: typeChecker
• getCompletionEntryDetails: typeChecker, log, target, sourceFile
• getCompletionsAtPosition: typeChecker, log, target, sourceFile
• getCompletionData: typeChecker, log, sourceFile

documentHighlights.ts: 638 lines

Exports: getDocumentHighlights

New parameters:

• getDocumentHighlights: typeChecker, cancellationToken, sourceFile

findAllReferences.ts: 1102 lines

Exports: getReferencedSymbolsForNode

New parameters:

• getReferencedSymbolsForNode: typeChecker, cancellationToken

goToDefinition.ts: 257 lines

Exports: getDefinitionAtPosition, getTypeDefinitionAtPosition

New parameters:

• getDefinitionAtPosition: program, sourcefile
  (I didn't want to pass in the whole program, but tryResolveScriptReference requires it and I don't want to do any refactoring in this commit.)
• createDefinitionFromSignatureDeclaration: typeChecker
• getDefinitionFromSymbol: typeChecker
• getTypeDefinitionAtPosition: typeChecker, sourceFile

jsDoc.ts: 403 lines

Exports: getJsDocCommentsFromDeclarations, getAllJsDocCompletionEntries

symbolDisplay.ts: 524 lines

Exports: getSymbolKind, getSymbolModifiers, getSymbolDisplayPartsDocumentationAndSymbolKind

New parameters:

• getSymbolDisplayPartsDocumentationAndSymbolKind: typeChecker
• getSymbolKindOfConstructorPropertyMethodAccessorFunctionOrVar: typeChecker
• getSymbolKind: typeChecker

utilities.ts:

Has 428 lines of new utilities at the top, taken out of services.ts.
I've checked that these are all used in multiple modules (else I would have moved them to the module they are used in).
Breaking the now 1376 lines of utilities apart into logical categories will be a job for another PR.

Other changes

• Many calls to program.gettypeChecker() have been replaced to just typeChecker parameter accesses. This should have no effect since getTypeChecker only has side effects the first time it is called.
• Removed BreakContinueSearchType, since that doesn't seem to be used.