Correct default compileOnSave value for different projects#10528
Merged
zhengbli merged 1 commit intoAug 25, 2016
Conversation
Contributor
|
👍 |
Contributor
|
ported to release-2.0 in 6c49dc2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The default parameter value for
compileOnSaveEnabledfor External projects were set totrue, but in calling the constructor, I used!!options.compileOnSaveEnabledwhich if not specified will befalse, thus overrides the actualtruedefault value. PR fixes the issue and make it more explicit.