Improve instanceof with structurally identical types#10216
Merged
ahejlsberg merged 4 commits intomasterfrom Aug 9, 2016
Merged
Improve instanceof with structurally identical types#10216ahejlsberg merged 4 commits intomasterfrom
ahejlsberg merged 4 commits intomasterfrom
Conversation
Member
|
In your example, what is the original type of |
Member
Author
|
@DanielRosenwasser Just fixed the example. |
Member
Author
|
I'm going to merge this since it is a fairly minor change and fixes some real world code breaks we'd otherwise see in the nightly build because of #10194. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves typing of
instanceofwith structurally identical types. A type S is now considered to be an instance of a type T ifThis specifically means that two distinct but structurally identical types (such as two classes) are not considered instances of each other:
These changes affect similar code written using user defined type predicates.
Fixes #7271.