Skip to content

Revert SqlScriptGeneratorOptions.IncludeSemicolons marked as deprecated #241

Open

Description

@acave-solweb

This option was marked as Deprecated in a recent PR, but I am unable to find a reason why this change was made.

<Summary>DEPRECATED: This option is non-functional and always behaves as if set to true. Semicolons are always included after statements regardless of this setting. This property is retained for API compatibility only and will be removed in a future version.</Summary>

Additionally, the deprecation notice was only added in a doc comment, without an Obsolete attribute, so no warnings have been thrown in code already using this property.

There's also no related mentions of IncludeSemicolons in release notes.

There have been some recent SSMS related feedback items related:
https://developercommunity.visualstudio.com/t/SSMS-SQL-Editor-formatter-forces-semicol/11160680
https://developercommunity.visualstudio.com/t/SQL-Formatter-Preview-add-option-to-di/11139122

Can we have this option reinstated and working?

  • Per a comment/suggestion from an above SSMS feedback item here, could it be expanded to provide an Always, Preserve, Required option?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions