Issue param in Get-GitHubIssue will always be set to 0#73
Merged
HowardWolosky merged 1 commit intomicrosoft:masterfrom Dec 13, 2018
Merged
Issue param in Get-GitHubIssue will always be set to 0#73HowardWolosky merged 1 commit intomicrosoft:masterfrom
HowardWolosky merged 1 commit intomicrosoft:masterfrom
Conversation
joseartrivera
requested review from
HowardWolosky,
danbelcher-MSFT and
etgottli
HowardWolosky
approved these changes
Dec 13, 2018
Contributor
HowardWolosky
left a comment
HowardWolosky
left a comment
There was a problem hiding this comment.
Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we changed the type of issue from string to int, the int will initialize at 0 and will fail our null check. This makes the code think that the Issue Param is always supplied. We should use $PSBoundParameters.ContainsKey to check this instead. This will fix issue #72.