Skip to content

Conversation

@joseartrivera
Copy link
Contributor

Added support for all of the Github Comment APIs.

Copy link
Contributor

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission. This is a great start, but I think that there is some opportunity for improvement.

You may also want to look at the Repository Comments docs that talks about commit comments. WIth a moderate amount of additional work you may be able to support all comment types with this PR. You can of course choose to defer and have these methods updated at some future point in time to support those additional values.

@joseartrivera
Copy link
Contributor Author

@HowardWolosky I will tackle repository comments (https://developer.github.com/v3/repos/comments/) in a seperate PR

Copy link
Contributor

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great updates. Almost there.

Copy link
Contributor

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remaining change requests

Copy link
Contributor

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Thanks!

HowardWolosky
HowardWolosky previously approved these changes Nov 30, 2018
Copy link
Contributor

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks!

Copy link
Contributor

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling the merge.

@HowardWolosky HowardWolosky merged commit 28b314b into microsoft:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants