Add GitHub Reactions support by TylerLeonhardt · Pull Request #193 · microsoft/PowerShellForGitHub

TylerLeonhardt · 2020-05-28T21:33:08Z

This adds the following cmdlets:

Get-GitHubReaction - https://developer.github.com/v3/reactions/#list-reactions-for-an-issue
Set-GitHubReaction - https://developer.github.com/v3/reactions/#create-reaction-for-an-issue
Remove-GitHubReaction - https://developer.github.com/v3/reactions/#delete-an-issue-reaction

The Get and Set can pipe into Remove
Get-GitHubIssue can pipe into Get and Set-GitHubReaction

I also added some tests.

NOTE: commit comments will come later.

NOTE: DO NOT REMOVE THESE REACTIONS THEY ARE USED IN A TEST:

HowardWolosky

Thanks so much for starting this effort!

I haven't had a chance to review the tests yet. I'll do so shortly. In the meantime, I have some comments for you to review and address in the code.

Nice job with adding in pipeline support! I'm still mulling over the idea of PassThru and the implications that would have for the rest of the module.

GitHubReactions.ps1

HowardWolosky · 2020-06-03T01:10:04Z

Thanks -- will give a final pass at this tomorrow, and then hopefully get it merged in.

HowardWolosky

Super minor nits, then ready to go. Will kick off CI in the meantime.

Tests/GitHubReactions.Tests.ps1

HowardWolosky · 2020-06-03T21:40:27Z

/azp run PowerShellForGitHub-CI

azure-pipelines · 2020-06-03T21:40:37Z

Azure Pipelines successfully started running 1 pipeline(s).

HowardWolosky · 2020-06-03T21:55:46Z

Static analysis failed:

##[warning]GitHubReactions.ps1(79,18): Warning : Command accepts pipeline input but has not defined a process block.
##[warning]GitHubReactions.ps1(84,17): Warning : Command accepts pipeline input but has not defined a process block.
##[warning]GitHubReactions.ps1(203,18): Warning : Command accepts pipeline input but has not defined a process block.
##[warning]GitHubReactions.ps1(208,17): Warning : Command accepts pipeline input but has not defined a process block.
##[warning]GitHubReactions.ps1(203,18): Warning : The parameter 'Uri' has been declared but not used. 
##[warning]GitHubReactions.ps1(216,18): Warning : The parameter 'NoStatus' has been declared but not used. 
##[warning]GitHubReactions.ps1(319,18): Warning : The parameter 'Uri' has been declared but not used. 
##[warning]GitHubReactions.ps1(330,18): Warning : The parameter 'NoStatus' has been declared but not used.

TylerLeonhardt · 2020-06-06T22:46:31Z

/azp run PowerShellForGitHub-CI

azure-pipelines · 2020-06-06T22:46:36Z

Commenter does not have sufficient privileges for PR 193 in repo microsoft/PowerShellForGitHub

HowardWolosky · 2020-06-18T18:02:57Z

Now that #242 is in, we have a standard way for handling the pipeline throughout the module. Are you willing to update this PR to adopt it? Thanks.

Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>

HowardWolosky

Thanks for the update and getting this aligned with the rest of the module's pipeline support after #242. Looks like there just a few more updates to make before this is ready to go in.

GitHubReactions.ps1

Tests/GitHubReactions.Tests.ps1

HowardWolosky · 2020-06-26T17:22:26Z

/azp run PowerShellForGitHub-CI

azure-pipelines · 2020-06-26T17:22:35Z

Azure Pipelines successfully started running 1 pipeline(s).

HowardWolosky · 2020-06-26T18:56:27Z

/azp run PowerShellForGitHub-CI

azure-pipelines · 2020-06-26T18:56:38Z

Azure Pipelines successfully started running 1 pipeline(s).

TylerLeonhardt · 2020-07-15T03:03:19Z

any thoughts?

HowardWolosky · 2020-07-15T17:06:33Z

any thoughts?

I was waiting for you to post an update removing the comments support just for this PR so that we could get it in. Then we can work through a good design to add back the comments support. That keeps a good code flow going without having this PR specifically grow and grow and grow.

TylerLeonhardt · 2020-07-15T18:24:28Z

removed

HowardWolosky · 2020-07-16T04:46:27Z

/azp run PowerShellForGitHub-CI

azure-pipelines · 2020-07-16T04:46:38Z

Azure Pipelines successfully started running 1 pipeline(s).

TylerLeonhardt · 2020-07-16T17:49:58Z

@HowardWolosky I don't think I impacted these failures

HowardWolosky · 2020-07-16T17:51:16Z

@HowardWolosky Howard Wolosky FTE I don't think I impacted these failures

Agreed -- there's some instability in a couple of the Repository tests that need to be investigated, but those are not considered blocking for getting this in. This should get merged today, and then we can work on adding-in comment support.

HowardWolosky · 2020-07-16T17:53:53Z

PowerShellForGitHub.psd1

-    # HelpInfo URI of this module
-    # HelpInfoURI = ''
-}
+# Copyright (c) Microsoft Corporation. All rights reserved.


@TylerLeonhardt - Can you take a quick look at this file? It looks like the whole file changed. Likely an encoding issue. Would be great if you could get it updated in the PR such that it reflects just the changed lines. Might require you to revert the file and then re-apply the changes. I've noticed that using the GitHub web resolver does this to the file.

HowardWolosky

Awesome. Thanks for this!

HowardWolosky suggested changes Jun 2, 2020

View reviewed changes

TylerLeonhardt commented Jun 2, 2020

View reviewed changes

GitHubReactions.ps1 Outdated Show resolved Hide resolved

TylerLeonhardt mentioned this pull request Jun 2, 2020

Support seamless pipelining of related cmdlets #63

Closed

HowardWolosky added enhancement An issue or pull request introducing new functionality to the project. api-reactions Work to complete the API's defined here: https://developer.github.com/v3/reactions labels Jun 2, 2020

HowardWolosky suggested changes Jun 3, 2020

View reviewed changes

Tests/GitHubReactions.Tests.ps1 Show resolved Hide resolved

Tests/GitHubReactions.Tests.ps1 Outdated Show resolved Hide resolved

HowardWolosky mentioned this pull request Jun 3, 2020

Add tests to GitHubRepositories.tests.ps1 #176

Merged

HowardWolosky added api completeness This is basic API functionality that hasn't been implemented yet. waiting for update Waiting for an update to the PR before the next review and removed enhancement An issue or pull request introducing new functionality to the project. labels Jun 18, 2020

TylerLeonhardt and others added 8 commits June 23, 2020 18:56

Add GitHub Reactions support

9fbc2b6

added note

a510502

Apply suggestions from code review

ee85c83

Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>

ShouldProcess and misc feedback

1fe71d2

remove PassThru

642dd45

Apply suggestions from code review

e960c27

Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>

static analysis

c975512

Add proper pipelining

77203bc

TylerLeonhardt force-pushed the added-github-reactions-support branch from 43dcb38 to 77203bc Compare June 24, 2020 18:54

add -Force

4d88a31

HowardWolosky suggested changes Jun 24, 2020

View reviewed changes

TylerLeonhardt added 2 commits June 24, 2020 21:16

address most of the feedback

b37462e

Update .input

1d2a5ac

TylerLeonhardt and others added 3 commits June 26, 2020 09:29

typo

da7f4ff

test fix for PS5

cc94932

Merge branch 'master' into added-github-reactions-support

a32df1b

Make PR test get only until Branch cmdlets are in

df88faf

HowardWolosky added waiting for update Waiting for an update to the PR before the next review and removed waiting for update Waiting for an update to the PR before the next review labels Jun 26, 2020

This was referenced Jun 29, 2020

Create/Get/Update/Delete references #97

Open

New GitHubRepositoryBranchProtectionRule Functions #255

Merged

Merge branch 'master' into added-github-reactions-support

88a3d90

HowardWolosky and others added 2 commits July 15, 2020 10:06

Merge branch 'master' into added-github-reactions-support

6ca62e5

remove comments

c33871b

HowardWolosky removed the waiting for update Waiting for an update to the PR before the next review label Jul 16, 2020

HowardWolosky reviewed Jul 16, 2020

View reviewed changes

LF to CRLF

7f4eb9b

HowardWolosky approved these changes Jul 16, 2020

View reviewed changes

Merge branch 'master' into added-github-reactions-support

8df4c78

HowardWolosky merged commit 8e55f5a into microsoft:master Jul 16, 2020

TylerLeonhardt deleted the added-github-reactions-support branch July 16, 2020 20:39

TylerLeonhardt mentioned this pull request Jul 16, 2020

Support Reactions of Comments #266

Open

3 tasks

Conversation

TylerLeonhardt commented May 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HowardWolosky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HowardWolosky commented Jun 3, 2020

Uh oh!

HowardWolosky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

HowardWolosky commented Jun 3, 2020

Uh oh!

azure-pipelines bot commented Jun 3, 2020

Uh oh!

HowardWolosky commented Jun 3, 2020

Uh oh!

TylerLeonhardt commented Jun 6, 2020

Uh oh!

azure-pipelines bot commented Jun 6, 2020

Uh oh!

HowardWolosky commented Jun 18, 2020

Uh oh!

HowardWolosky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HowardWolosky commented Jun 26, 2020

Uh oh!

azure-pipelines bot commented Jun 26, 2020

Uh oh!

HowardWolosky commented Jun 26, 2020

Uh oh!

azure-pipelines bot commented Jun 26, 2020

Uh oh!

TylerLeonhardt commented Jul 15, 2020

Uh oh!

HowardWolosky commented Jul 15, 2020

Uh oh!

TylerLeonhardt commented Jul 15, 2020

Uh oh!

HowardWolosky commented Jul 16, 2020

Uh oh!

azure-pipelines bot commented Jul 16, 2020

Uh oh!

TylerLeonhardt commented Jul 16, 2020

Uh oh!

HowardWolosky commented Jul 16, 2020

Uh oh!

HowardWolosky Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

TylerLeonhardt Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

HowardWolosky left a comment

Choose a reason for hiding this comment

TylerLeonhardt commented May 28, 2020 •

edited

Loading