Skip to content

Replaces instances of anyOf to oneOf - #264

Merged
Irvine Sunday (irvinesunday) merged 27 commits into
masterfrom
fix/is/anyOf-oneOf-inversion
Sep 8, 2022
Merged

Irvine Sunday (irvinesunday) merged 27 commits into
masterfrom
fix/is/anyOf-oneOf-inversion

Conversation

@irvinesunday

Copy link
Copy Markdown
Contributor

Fixes #245

This PR:

  • Replaces anyOf to oneOf for geometric points.
  • Replaces instances of anyOf to oneOf for Decimal, Double, Single and Int64 EdmPrimitiveTypeKind.
  • Updates unit and integration tests.
  • Make components for floating point numbers.

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this, a couple of remarks

…rator.cs

Co-authored-by: Vincent Biret <vibiret@microsoft.com>

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I missed the affectation

@baywet

Copy link
Copy Markdown
Member

I think some unit tests still need to be updated and we should be good to go after that.

This is because `Explode = false` for the OData query parameters.
@irvinesunday
Irvine Sunday (irvinesunday) deleted the fix/is/anyOf-oneOf-inversion branch September 8, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

translation to anyOf and oneOf has been inverted throughout the conversion process

2 participants