Skip to content

Better error handling - #785

Merged
Maggie Kimani (MaggieKimani1) merged 7 commits into
vnextfrom
fix/better-error-display
Mar 8, 2022
Merged

Maggie Kimani (MaggieKimani1) merged 7 commits into
vnextfrom
fix/better-error-display

Conversation

@MaggieKimani1

Copy link
Copy Markdown
Contributor

Fixes #784

  • Passes the cancellation token from the system.command line host to async APIs to avoid getting task cancelled exceptions when users press ctrl + c
  • Formats the logging to use templates instead of doing string interpolation so logging APIs can do sampling and metrics

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for starting the work here, a couple of comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better Exception handling in Hidi

2 participants