Skip to content

- upgrades odata conversion lib reference in hidi - #753

Merged
Vincent Biret (baywet) merged 3 commits into
vnextfrom
feature/conversion-lib-upgrade
Feb 28, 2022
Merged

Vincent Biret (baywet) merged 3 commits into
vnextfrom
feature/conversion-lib-upgrade

Conversation

@baywet

Copy link
Copy Markdown
Member

No description provided.

DeclarePathParametersOnPathItem = true,
EnableKeyAsSegment = true,
EnableOperationId = true,
ErrorResponsesAsDefault = false,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these updated settings Kiota-specific or will they apply to all clients?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AddSingleQuotesForStringParameters is actually a bugfix, but Sam was worried it'd break some people, so we added a setting, IMHO this should be true by default
AddEnumDescriptionExtension just adds a x-ms-enum-description extension for enum members descriptions, it's more information (autorest uses the same extension)
DeclarePathParametersOnPathItem is optimization, to avoid duplicating parameters that are common to operations. I think the optimization will also be beneficial to other generators
ErrorResponsesAsDefault makes the description more specific, using 4XX and 5XX error code classes instead of default (which could be something else than an error)

@baywet
Vincent Biret (baywet) merged commit de4ea22 into vnext Feb 28, 2022
@baywet
Vincent Biret (baywet) deleted the feature/conversion-lib-upgrade branch February 28, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants