Skip to content

updates pipeline definition to align with openapi.odata lib changes - #752

Merged
Vincent Biret (baywet) merged 8 commits into
vnextfrom
feature/pipeline-upgrades
Mar 1, 2022
Merged

Vincent Biret (baywet) merged 8 commits into
vnextfrom
feature/pipeline-upgrades

Conversation

@baywet

@baywet Vincent Biret (baywet) commented Feb 28, 2022 •

Copy link
Copy Markdown
Member

This PR pushes multiple improvements to the pipeline definition:

  • Swaps ms build and vstest tasks by dotnet cli, to prepare an eventual transition to an ubuntu agent (performance) and for clarity
  • Adds policheck, credscan, binskim, and antimalware scan tasks (compliance)
  • Adds a deploy stage to avoid relying on the older release management, and use the same approbation rules defined in the environment across projects.

One thing I haven't included is the "has the version been bumped test" because I think further changes should be done to this pipeline:

  • The deploy job should be splat into 3 jobs (deploy open API, deploy readers, deploy hidi) so each module can be deployed indenpendently from one another.
  • Before each of those jobs, should be a reflective "check-openapi/reader/hidi version has been bumped" job that'd fail in case this was forgotten.

https://microsoftgraph.visualstudio.com/Graph%20Developer%20Experiences/_build/results?buildId=68725&view=results

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why the poliCheck for tool step is failing?

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet

Copy link
Copy Markdown
Member Author

Maggie Kimani (@MaggieKimani1) policheck and the later binskim issues have been fixed (inexistant or wrong paths)

I've rebased my PR after #750 was merged.
I've also taken the code from your test azure pipeline (github release for hidi) as well as splat the deploy stage in 3 deploy jobs so we can release things independently.

@baywet

Copy link
Copy Markdown
Member Author

Comment thread .azure-pipelines/ci-build.yml Resolved
@MaggieKimani1

Copy link
Copy Markdown
Contributor

Maggie Kimani (@MaggieKimani1) policheck and the later binskim issues have been fixed (inexistant or wrong paths)

I've rebased my PR after #750 was merged. I've also taken the code from your test azure pipeline (github release for hidi) as well as splat the deploy stage in 3 deploy jobs so we can release things independently.

Thanks for taking my changes and adding them to this PR.

Co-authored-by: Maggie Kimani <maggiekim42@gmail.com>
@baywet

Vincent Biret (baywet) commented Mar 1, 2022 •

Copy link
Copy Markdown
Member Author

@baywet
Vincent Biret (baywet) merged commit 082f0bd into vnext Mar 1, 2022
@baywet
Vincent Biret (baywet) deleted the feature/pipeline-upgrades branch March 1, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants