Skip to content

Feature/add validator for path parameters not present in path - #524

Merged
Darrel (darrelmiller) merged 7 commits into
microsoft:vnextfrom
DCollart:feature/add_validator_for_path_parameters_not_present_in_path
May 22, 2021
Merged

Darrel (darrelmiller) merged 7 commits into
microsoft:vnextfrom
DCollart:feature/add_validator_for_path_parameters_not_present_in_path

Conversation

@DCollart

Copy link
Copy Markdown
Contributor

Fixes #523

For that new rule I used the "PathString" of the context in order to do the check.

I could also maybe have put that rule at the "Path" level, what do you think ?

@ghost

Deleted user (ghost) commented Oct 1, 2020 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@darrelmiller

Copy link
Copy Markdown
Member

Doing the validation at the parameter level is better. There is an exception that was introduced in 3.1 that says if the path Item is empty, then the required parameter rule is not applied. https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.1.0.md#path-templating

@darrelmiller Darrel (darrelmiller) added this to the 1.2.4 milestone Oct 11, 2020
@darrelmiller Darrel (darrelmiller) modified the milestones: 1.2.4, 1.3 Feb 28, 2021
@darrelmiller
Darrel (darrelmiller) changed the base branch from master to vnext March 14, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Path parameter not present in the path : No error

2 participants