Repository navigation
Supporting all header fields inside components/headers - #366
Merged
PerthCharern merged 5 commits intoDec 28, 2018
Merged
Conversation
Contributor
|
Thank you for your contribution Vitaliy Kurokhtin (@VitaliyKurokhtin) 😄 I agree with your reading of the spec. Our Header deserializer should recognize all the properties in the parameter object except name and in. Could you help fix the test a bit? - and I'll help check this in. |
PerthCharern
suggested changes
Dec 13, 2018
PerthCharern
left a comment
Contributor
There was a problem hiding this comment.
See feedback above.
Contributor
Author
|
Test improved. |
Darrel (darrelmiller)
approved these changes
Dec 22, 2018
PerthCharern
approved these changes
Dec 28, 2018
Contributor
|
Thanks for writing this Vitaliy Kurokhtin (@VitaliyKurokhtin)! |
Vitaliy Kurokhtin (VitaliyKurokhtin)
deleted the
vvk/component-headers
branch
December 28, 2018 22:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification says HeaderObject is a ParameterObject with some minor differences: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#headerObject
components/headers at the same time is defined as Map[string, Header Object | Reference Object]: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#componentsObject
which leads me to believe that components/headers should support full set of properties allowed for ParameterObject with exception of "name" and "in"