Skip to content

Ensure parsing null in "in" in Parameter does not fail - #329

Merged
PerthCharern merged 3 commits into
masterfrom
perthcharern/AllowParsingNullForParameterLocation
Oct 12, 2018
Merged

PerthCharern merged 3 commits into
masterfrom
perthcharern/AllowParsingNullForParameterLocation

Conversation

@PerthCharern

@PerthCharern PerthCharern commented Oct 9, 2018 •

Copy link
Copy Markdown
Contributor

Fix #309, #297

  • Ensure that null in "in" in parameter object is parsed to a null Im in the DOM.

  • Add validation rule to validate the required fields in Parameter.

… in the DOM.

- Add validation rule to validate the required fields in Parameter.
Add a few more tests
{
context.CreateError(
nameof(RequiredMustBeTrueWhenInIsPath),
"\"required\" must be true when parameter location is path");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path [](start = 82, length = 4)

in quotes

@Shwetap05 Shweta Patil (Shwetap05) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@PerthCharern
PerthCharern merged commit f1864c6 into master Oct 12, 2018
@PerthCharern
PerthCharern deleted the perthcharern/AllowParsingNullForParameterLocation branch October 12, 2018 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants