Repository navigation
Fix header deserialization in V2 documents - #261
Merged
Merged
Conversation
| case "multi": | ||
| h.Style = ParameterStyle.Form; | ||
| h.Explode = true; | ||
| return; |
Contributor
There was a problem hiding this comment.
"multi" is now allowed in the header in V2 spec. Looks like it's only allowed in Param. #Closed
Contributor
| return header; | ||
| } | ||
|
|
||
| private static void LoadStyle(OpenApiHeader h, string v) |
Contributor
There was a problem hiding this comment.
Could we use full word here? header and format instead of h and v.
| return; | ||
| case "tsv": | ||
| throw new NotSupportedException(); | ||
| } |
Contributor
There was a problem hiding this comment.
} [](start = 9, length = 4)
Looks like we should throw an error for case default? That would indicate that the document is broken in V2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several fields were not supported and some were supported that don't exist in V2. I also re-ordered the parsing code to match the spec order.