Repository navigation
Fix for writing DateTimeOffset values - #246
Merged
Merged
Conversation
Contributor
| var json = WriteAsJson(dateTimeValue); | ||
|
|
||
| // Assert | ||
| json.Should().Be(input.ToString(@"o")); |
Contributor
There was a problem hiding this comment.
@ [](start = 44, length = 1)
nit, @ not needed #Closed
Member
Author
|
Probably a good idea. I will add that.
…________________________________
From: PerthCharern <notifications@github.com>
Sent: Friday, April 27, 2018 12:32:35 PM
To: Microsoft/OpenAPI.NET
Cc: Darrel Miller; Author
Subject: Re: [Microsoft/OpenAPI.NET] Fix for writing DateTimeOffset values (#246)
}
On a related note, should we also call long.TryParse in the ValueNode in the Reader?
https://github.com/Microsoft/OpenAPI.NET/blob/bd61abdfee72445d52312d70f04db087e6d30cf9/src/Microsoft.OpenApi.Readers/ParseNodes/ValueNode.cs.
________________________________
Refers to: src/Microsoft.OpenApi/Writers/OpenApiWriterBase.cs:211 in e4c7a0e<e4c7a0e>. [](commit_id = e4c7a0e<e4c7a0e>, deletion_comment = False)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#246 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAbUzkhTiVQF5iWYh4YQrqEnPfv5OH5oks5ts0gjgaJpZM4Tqj88>.
#Resolved
|
…penAPI.NET into dm/dateTimeOffsetBug
Member
Author
|
PerthCharern Any idea why we have this license/cla check that is holding up the PR? |
Contributor
|
The check evaluates whether a CLA needs to be signed for Microsoft (based on various factors like contributor(s), size of the change, etc.) I have seen cases where it occasionally hangs up indefinitely for some reason. In that case, the fastest way to resolve it is to commit a new whitespace change. |
Member
Author
|
PerthCharern I knew what it was, I just couldn't understand why it was an issue. I'll try the whitespace trick. |
Contributor
|
That I don't know. It started happening recently. I'll get in touch with the OSS team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #243