Skip to content

Fix for writing DateTimeOffset values - #246

Merged
Darrel (darrelmiller) merged 5 commits into
masterfrom
dm/dateTimeOffsetBug
May 1, 2018
Merged

Darrel (darrelmiller) merged 5 commits into
masterfrom
dm/dateTimeOffsetBug

Conversation

@darrelmiller

Copy link
Copy Markdown
Member

Addresses #243

@PerthCharern

PerthCharern commented Apr 27, 2018 •

Copy link
Copy Markdown
Contributor
    public void ParseScalarIntegertAsAnyShouldSucceed()

nit, not related to your change but I just happened to notice it. Could you remove the t? #Closed


Refers to: test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiAnyTests.cs:83 in e4c7a0e. [](commit_id = e4c7a0e, deletion_comment = False)

var json = WriteAsJson(dateTimeValue);

// Assert
json.Should().Be(input.ToString(@"o"));

@PerthCharern PerthCharern Apr 27, 2018 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ [](start = 44, length = 1)

nit, @ not needed #Closed

@PerthCharern

PerthCharern commented Apr 27, 2018 •

Copy link
Copy Markdown
Contributor
        }

On a related note, should we also call long.TryParse in the ValueNode in the Reader?

https://github.com/Microsoft/OpenAPI.NET/blob/bd61abdfee72445d52312d70f04db087e6d30cf9/src/Microsoft.OpenApi.Readers/ParseNodes/ValueNode.cs. #Closed


Refers to: src/Microsoft.OpenApi/Writers/OpenApiWriterBase.cs:211 in e4c7a0e. [](commit_id = e4c7a0e, deletion_comment = False)

@PerthCharern PerthCharern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@darrelmiller

Darrel (darrelmiller) commented Apr 27, 2018 via email •

Copy link
Copy Markdown
Member Author

@darrelmiller

Copy link
Copy Markdown
Member Author

PerthCharern Any idea why we have this license/cla check that is holding up the PR?

@PerthCharern

PerthCharern commented Apr 30, 2018 •

Copy link
Copy Markdown
Contributor

Darrel (@darrelmiller)

The check evaluates whether a CLA needs to be signed for Microsoft (based on various factors like contributor(s), size of the change, etc.)

I have seen cases where it occasionally hangs up indefinitely for some reason. In that case, the fastest way to resolve it is to commit a new whitespace change.

@darrelmiller

Copy link
Copy Markdown
Member Author

PerthCharern I knew what it was, I just couldn't understand why it was an issue. I'll try the whitespace trick.

@PerthCharern

Copy link
Copy Markdown
Contributor

That I don't know. It started happening recently. I'll get in touch with the OSS team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants