Skip to content

fix: enum description number values - #2023

Merged
Vincent Biret (baywet) merged 1 commit into
devfrom
fix/enum-description-int-values
Dec 24, 2024
Merged

Vincent Biret (baywet) merged 1 commit into
devfrom
fix/enum-description-int-values

Conversation

@baywet

Copy link
Copy Markdown
Member

Signed-off-by: Vincent Biret vibiret@microsoft.com

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Comment on lines +102 to +105
if (value.GetValueKind() == JsonValueKind.Number)
Value = value.GetValue<decimal>().ToString(CultureInfo.InvariantCulture);
else
Value = value.GetValue<string>();

Check notice

Code scanning / CodeQL

Missed ternary opportunity

Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.
@sonarqubecloud

Copy link
Copy Markdown

@baywet
Vincent Biret (baywet) deleted the fix/enum-description-int-values branch December 24, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants