Repository navigation
Make OpenAPI.NET library trim-compatible - #1717
Maggie Kimani (MaggieKimani1) merged 20 commits into
Conversation
dd82b66 to
4611a36
Compare
4611a36 to
11466d7
Compare
82a5bf9 to
a7add49
Compare
a7add49 to
5b006b2
Compare
Vincent Biret (baywet)
left a comment
There was a problem hiding this comment.
I think it'd be interesting to set-up a trimming test project to ensure no regressions happen in the future here.
microsoft/kiota-dotnet#291
microsoft/kiota-dotnet#295
microsoft/kiota-dotnet#296
|
Thanks for the reviews Darrel (@darrelmiller) and Maggie Kimani (@MaggieKimani1) -- I spotted a few more issues after adding a TrimmingTest project (mostly related to ValidationRuleset) so we'll need to hold off on merging this a bit longer. |
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
5a01836 to
06b54c3
Compare
|
Vincent Biret (@baywet) Eric Erhardt (@eerhardt) I think this is good for one last review... |
Vincent Biret (baywet)
left a comment
There was a problem hiding this comment.
Thank you for this great contribution! And for the ongoing discussion here.
76f8851 to
35811cc
Compare
|
Maggie Kimani (@MaggieKimani1) for final review and merge |
Eric Erhardt (eerhardt)
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
6200767
|
LGTM! |
This PR removes the use of reflection in
GetDisplayNamefor enums and adds[DynamicallyAccessMembers]attributes toCloneFromCopyConstructor.Prior to this change, using the
Microsoft.OpenApipackage in an application with trimming enabled would present the following warnings:Closes #1715
Closes #1114