Skip to content

Fix OpenApiStreamReader.ReadAsync doesn't respect "leave open" setting - #1581

Merged
Maggie Kimani (MaggieKimani1) merged 3 commits into
vnextfrom
mk/fix-stream-leave-open
Mar 6, 2024
Merged

Maggie Kimani (MaggieKimani1) merged 3 commits into
vnextfrom
mk/fix-stream-leave-open

Conversation

@MaggieKimani1

Copy link
Copy Markdown
Contributor

Fixes #1579

@sonarqubecloud

sonarqubecloud Bot commented Mar 6, 2024

Copy link
Copy Markdown

@MaggieKimani1
Maggie Kimani (MaggieKimani1) deleted the mk/fix-stream-leave-open branch March 6, 2024 10:19

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change also needs to be implemented lines 44 and 89 for consistency.
Thanks for addressing this super fast!

@MaggieKimani1

Copy link
Copy Markdown
Contributor Author

The change also needs to be implemented lines 44 and 89 for consistency. Thanks for addressing this super fast!

Here's the PR: #1582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenApiStreamReader.Read/ReadAsync doesn't honour "leaveOpen"Setting

3 participants