Skip to content

Add ValidationRuleSet.Remove - #1535

Merged
Vincent Biret (baywet) merged 56 commits into
microsoft:vnextfrom
LucGenetier:master
Jan 24, 2024
Merged

Vincent Biret (baywet) merged 56 commits into
microsoft:vnextfrom
LucGenetier:master

Conversation

@LucGenetier

Copy link
Copy Markdown
Contributor

No description provided.

Vincent Biret (baywet) and others added 30 commits May 11, 2022 08:00
master refresh for hidi release
@baywet
Vincent Biret (baywet) changed the base branch from master to vnext January 22, 2024 15:11

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Here are a few comments

@baywet

Copy link
Copy Markdown
Member

Can you also rebase onto vnext please so we don't get all this merge commits in the way?

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, a couple more recommendations

@LucGenetier

Copy link
Copy Markdown
Contributor Author

ok


In reply to: 1904236027

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, minor comments edits I'll commit right-away

@baywet
Vincent Biret (baywet) enabled auto-merge (squash) January 24, 2024 13:27
@baywet
Vincent Biret (baywet) merged commit 51d7b30 into microsoft:vnext Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants