Skip to content

add the date types and any type - #15

Merged
Sam Xu (xuzhg) merged 1 commit into
microsoft:masterfrom
xuzhg:R_D_Any
Oct 17, 2017
Merged

Sam Xu (xuzhg) merged 1 commit into
microsoft:masterfrom
xuzhg:R_D_Any

Conversation

@xuzhg

Copy link
Copy Markdown
Contributor
  1. Add the primitive data types
  2. And Any type

It's just for discussion.

@darrelmiller

Copy link
Copy Markdown
Member

I was hesitant about this at first because determining the type when reading from a JSON/YAML source is challenging, but that's a problem for the reader and should not limit the model description.

We should also ensure that the known primitive formats are somehow extensible as there are future plans to create a registry of known formats and I know OData has a bunch more formats that it defines. We should have a way of registering more known formats. Again perhaps this is just a problem for readers. As long as we can derive from OpenApiPrimative, the model should be able to support additional primitives.

@xuzhg

Copy link
Copy Markdown
Contributor Author

See related issue opened at: #14

@xuzhg

Copy link
Copy Markdown
Contributor Author

Darrel (@darrelmiller) I merged this change. We can change later.

@xuzhg
Sam Xu (xuzhg) merged commit 9c036dc into microsoft:master Oct 17, 2017
@xuzhg
Sam Xu (xuzhg) deleted the R_D_Any branch October 17, 2017 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants