Skip to content

Update slicing of OpenAPI document to include path parameters #834

Closed

Description

This setting in the conversion lib enables us to declare path parameters at the path item level when converting from CSDL to OpenAPI:
DeclarePathParametersOnPathItem=true.
This setting is set to true in Hidi when converting from CSDL to OpenAPI. When slicing the OpenAPI document to obtain a subset document in the OpenAPIFilterService, the OpenApiPathItem parameters from the main OpenAPI document don't get copied over to the subset document.

Activity

  1. ddyett commented on Apr 28, 2022

    @ddyett
    Member

    vivian (@adhiambovivian) Irvine Sunday (@irvinesunday) Carol Kigoonya (@CarolKigoonya) how far are we from fixing this. My understanding is that it's blocking PowerShell based on the comments in Irvine's PR above.

    //cc Peter Ombwa (@peombwa)

  2. irvinesunday commented on May 4, 2022

    @irvinesunday
    ContributorAuthor

    vivian (@adhiambovivian) Irvine Sunday (@irvinesunday) Carol Kigoonya (@CarolKigoonya) how far are we from fixing this. My understanding is that it's blocking PowerShell based on the comments in Irvine's PR above.

    //cc Peter Ombwa (@peombwa)

    We have reverted this setting in DevX API to unblock PowerShell in the interim.

  3. added this to the 1.4 milestone on May 11, 2022
  4. removed their assignment
    on May 11, 2022
  5. CarolKigoonya commented on May 16, 2022

    @CarolKigoonya
    Contributor

    We are working on design to address the issue, but reverting should have unblocked PowerShell Peter Ombwa (@peombwa) and Maísa Rissi (@maisarissi) please confirm

  6. added
    priority:p1High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days
    on May 16, 2022
  7. peombwa commented on May 16, 2022

    @peombwa
    Contributor

    Carol Kigoonya (@CarolKigoonya), I can confirm that the revert unblocked PowerShell!

  8. darrelmiller commented on Jul 5, 2022

    @darrelmiller
    Member

    Vincent Biret (@baywet) I'm assuming this issue is still affecting Kiota self-serve usage.

  9. baywet commented on Jul 5, 2022

    @baywet
    Member

    correct

  10. irvinesunday commented on Jul 12, 2022

    @irvinesunday
    ContributorAuthor

    We are working on this resolution
    cc: Maggie Kimani (@MaggieKimani1)

  11. baywet commented on Jul 15, 2022

    @baywet
    Member

    To be more specific, I believe the impact is wider than just slicing, even the current full beta/v1 descriptions with have in the metadata repo are missing the user-id path parameter for '/users/{user-id}'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

priority:p1High priority but not blocking. Causes major but not critical loss of functionality SLA <=7daystype:bugA broken experience

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions